Codecov Report

Attention: Patch coverage is 92.30769% with 3 lines in your changes missing coverage. Please review.

Project coverage is 59.39%. Comparing base (294bbbc) to head (a1cdf3c).
Report is 2 commits behind head on main.

@@            Coverage Diff             @@
##             main    #8342      +/-   ##
==========================================
- Coverage   59.39%   59.39%   -0.01%     
==========================================
  Files         370      370              
  Lines       39987    40010      +23     
==========================================
+ Hits        23750    23763      +13     
- Misses      14745    14753       +8     
- Partials     1492     1494       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

I understand there is a requirement from the community to back up resources under the labelled namespace, but we can also do that by using the namespace filter, do we need a new way to do the same function?

Some admins may find it easier to automate ns backup by label.
Perhaps individual small teams label their resources.
In some orgs, not everyone will have RBAC to create modify backups.velero.io custom resources.
And backing up by including the label may be a preferred way if available for some.

Apart from velero issue this pr fixes, it has also been requested to our team in https://issues.redhat.com/browse/OADP-4572

I think the question is, when is the current behavior of backing up namespace but not namespaced resources within it desirable?

The previous fix already decided that any namespace not included by namespace filters like label should not be in the backup.

Now we're just saying every namespace included via namespace filters (including label) will have namespaced resources of those namespaces in the backup.

@kaovilai Thanks for this PR, but have we reached agreement in terms of whether we should implement it?
cc @blackpiglet

I don't think we have reached agreements yet.

@kaovilai
We can discuss scenarios requiring labels as the namespace filters, but please note this is a break change.

I agree that only backing up the namespace with selected labels without any resources in it is not a common use case, but at least, we have that option.

After introducing this change, we lost that option.

If the introduced method is the preferable option, we can go forward that way, but before applying it, I think we need to make sure that.

Another thing with this implementation is that namespaces included via label selector would not show up in backup describe under IncludedNamespaces, but would likely still show in Resource List. I think that should be good enough.

@kaovilai v1.16 candidate?

Please add this PR to v1.16 milestone